[webkit-reviews] review granted: [Bug 36021] support lang attribute on <option> elements : [Attachment 50516] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 11 11:00:09 PST 2010


Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 36021: support lang attribute on <option> elements
https://bugs.webkit.org/show_bug.cgi?id=36021

Attachment 50516: Patch
https://bugs.webkit.org/attachment.cgi?id=50516&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    String lang = getAttribute(node, langAttr);

You can make this code slightly more efficient by making the type of "lang" be
const AtomicString&.

r=me


More information about the webkit-reviews mailing list