[webkit-reviews] review requested: [Bug 36009] Unused functions in yarr interpreter : [Attachment 50485] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 11 04:13:34 PST 2010
Peter Varga <pvarga at inf.u-szeged.hu> has asked for review:
Bug 36009: Unused functions in yarr interpreter
https://bugs.webkit.org/show_bug.cgi?id=36009
Attachment 50485: proposed patch
https://bugs.webkit.org/attachment.cgi?id=50485&action=review
------- Additional Comments from Peter Varga <pvarga at inf.u-szeged.hu>
I have found two functions in RegexInterpreter.cpp:
tryConsumeCharacter() and tryConsumeCharacterClass() which are never called.
If these functions are reserved for future using the tryConsumeCharacter
is deprecated, because the ignoreCase checking is
unnecessary in this phase of regex matching.
More information about the webkit-reviews
mailing list