[webkit-reviews] review denied: [Bug 35993] [Qt] Should not access key modifier be the Alt key? : [Attachment 50448] Proposed patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Diego Gonzalez
<diego.gonzalez at openbossa.org>'s request for review:
Bug 35993: [Qt] Should not access key modifier be the Alt key?
https://bugs.webkit.org/show_bug.cgi?id=35993

Attachment 50448: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=50448&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Good catch, Diego!

Ironically I changed it from Alt to Ctrl in revision 29688 :-)

Today for example fast/forms/legend-access-key.html expects ctrl on platforms
where the user agent contains "Mac OS X" and alt on the others. So I think the
_correct_ fix would be to return Ctrl for OS(MAC_OS_X) and Alt otherwise.