[webkit-reviews] review granted: [Bug 35892] REGRESSION(r55684): branch8 and branchTest8 should be implemented on all platform : [Attachment 50293] Buildfix for Thumb2 after r55684. Add branch8 and branchTest8 functions.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 10 21:40:34 PST 2010


Gavin Barraclough <barraclough at apple.com> has granted Gabor Loki
<loki at webkit.org>'s request for review:
Bug 35892: REGRESSION(r55684): branch8 and branchTest8 should be implemented on
all platform
https://bugs.webkit.org/show_bug.cgi?id=35892

Attachment 50293: Buildfix for Thumb2 after r55684. Add branch8 and branchTest8
functions.
https://bugs.webkit.org/attachment.cgi?id=50293&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
// use addressTempRegister incase the branchTest32 we call uses
dataTempRegister. :-/

Copy & pasted comment, 'branchTest32' should be 'branchTest8' in this case.
The code all looks great, r=me.


More information about the webkit-reviews mailing list