[webkit-reviews] review requested: [Bug 35991] Would be faster to not use a thread specific to implement StringImpl::empty() : [Attachment 50456] The patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 10 17:21:44 PST 2010


Gavin Barraclough <barraclough at apple.com> has asked  for review:
Bug 35991: Would be faster to not use a thread specific to implement
StringImpl::empty()
https://bugs.webkit.org/show_bug.cgi?id=35991

Attachment 50456: The patch
https://bugs.webkit.org/attachment.cgi?id=50456&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Added call to UStringImpl::empty() from initializeThreadingOnce() to ensure
empty() is called in a threadsafe fashion the first time it is used.
Added call to StringImpl::empty() from the ThreadGlobalData constructor, to
ensure empty() has been called from the main thread before any further threads
are created.


More information about the webkit-reviews mailing list