[webkit-reviews] review denied: [Bug 35991] Would be faster to not use a thread specific to implement StringImpl::empty() : [Attachment 50447] The patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied  review:
Bug 35991: Would be faster to not use a thread specific to implement
StringImpl::empty()
https://bugs.webkit.org/show_bug.cgi?id=35991

Attachment 50447: The patch
https://bugs.webkit.org/attachment.cgi?id=50447&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Sorry -- I said r- on IRC because DEFINE_STATIC_LOCAL is not threadsafe. The
solution we agreed upon was to add a call to empty() at startup, to ensure that
initialization of the shared empty static occurs before any JSC or WebCore
threads are created.