[webkit-reviews] review granted: [Bug 35943] Make Document::postTask to use a single queue of tasks, to fire them in order : [Attachment 50434] patch with updated App Cache test.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dmitry Titov <dimich at chromium.org>'s
request for review:
Bug 35943: Make Document::postTask to use a single queue of tasks, to fire them
in order
https://bugs.webkit.org/show_bug.cgi?id=35943

Attachment 50434: patch with updated App Cache test.
https://bugs.webkit.org/attachment.cgi?id=50434&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    if (!isTimerPosted) {
> +	   isTimerPosted = true;
> +	   CFRunLoopAddTimer(CFRunLoopGetCurrent(), CFRunLoopTimerCreate(0, 0,
0, 0, 0, timerFired, 0), kCFRunLoopCommonModes);
> +    }

I normally write these as early returns instead of nesting the code.

> > Is the assertion correct? Maybe the isMainThread assertion belongs inside
the
> > #else of the USE(WEB_THREAD)?
>
> It is correct to check for IsMainThread because in this case WTF's idea of
main
> thread is the same as webThread (http://trac.webkit.org/changeset/52046)

If that is so, then why do we need the WEB_THREAD assertion at all?