[webkit-reviews] review granted: [Bug 35986] VoiceOver can navigate to hidden content in widget (WAI-ARIA) : [Attachment 50439] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 10 14:51:23 PST 2010


Beth Dakin <bdakin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 35986: VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986

Attachment 50439: Patch
https://bugs.webkit.org/attachment.cgi?id=50439&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Generally, I think this patch is good, so r=me. However, I don't like having
two functions called accessibilityIsIgnored() and
accessibilityIsIgnoredCommon(). I wish the names of these functions made the
differences between the two more obvious. Maybe we could think of better names.
Chris, could you explain what you think the difference is between the two, and
perhaps that will inspire better names?


More information about the webkit-reviews mailing list