[webkit-reviews] review requested: [Bug 35943] Make Document::postTask to use a single queue of tasks, to fire them in order : [Attachment 50434] patch with updated App Cache test.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 10 13:56:19 PST 2010


Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 35943: Make Document::postTask to use a single queue of tasks, to fire them
in order
https://bugs.webkit.org/show_bug.cgi?id=35943

Attachment 50434: patch with updated App Cache test.
https://bugs.webkit.org/attachment.cgi?id=50434&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
I think the discussion here, in bug 32047 and the current AC spec seem to
converge on treating the AppCache events as async and able to come in any order
related to postMessage event in this test.
I've updated the test so it is not dependent on the order of tasks, and waits
for 3 signals in any order: AC events 'checking' and 'noupdate' and a  message
from the subframe.
Also test prints order of all events if loaded in browser manually.

Correction to my above statement: FF 3.6 actually behaves exactly as WebKit
will after this patch, wrt the set and order of those events. I didn't clear
the app cache of FF while doing experiments...


More information about the webkit-reviews mailing list