[webkit-reviews] review granted: [Bug 35952] [chromium] Mouse wheel events don't get propagated to plugins : [Attachment 50380] Updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 10 10:48:10 PST 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted John
Abd-El-Malek <jam at chromium.org>'s request for review:
Bug 35952: [chromium] Mouse wheel events don't get propagated to plugins
https://bugs.webkit.org/show_bug.cgi?id=35952
Attachment 50380: Updated patch
https://bugs.webkit.org/attachment.cgi?id=50380&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/src/WebInputEventConversion.cpp
> +WebMouseWheelEventBuilder::WebMouseWheelEventBuilder(const
WebCore::ScrollView* view, const WebCore::WheelEvent& event)
...
> + scrollByPage = event.granularity() == WebCore::WheelEvent::Page;
^^^ no need for WebCore:: prefix since there is a 'using namespace WebCore'
up above.
More information about the webkit-reviews
mailing list