[webkit-reviews] review granted: [Bug 35976] On Window, dwItemData from a custom context menu item cannot be retrieved when that item is selected. : [Attachment 50413] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Ada Chan
<adachan at apple.com>'s request for review:
Bug 35976: On Window, dwItemData from a custom context menu item cannot be
retrieved when that item is selected.
https://bugs.webkit.org/show_bug.cgi?id=35976

Attachment 50413: Patch
https://bugs.webkit.org/attachment.cgi?id=50413&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 55785)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,13 @@
> +2010-03-10  Ada Chan  <adachan at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=35976
> +
> +	   Retrieve any dwItemData that's set on the context menu item in
contextMenuItemByIdOrPosition().

I think you should mention that this is useful for WebKit clients who store
data in this member for their custom menu items.

r=me

-Adam