[webkit-reviews] review granted: [Bug 35899] Switching malloc implementations requires a world rebuild : [Attachment 50369] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 35899: Switching malloc implementations requires a world rebuild
https://bugs.webkit.org/show_bug.cgi?id=35899

Attachment 50369: patch
https://bugs.webkit.org/attachment.cgi?id=50369&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
It seems that tcmalloc version of fastMallocSize could still use some work. To
match OS-provided ones, it should return 0 for pointers to unallocated memory,
but there are at least two cases when it doesn't:

1) It will crash if span is null.
2) It disregards low bits of a pointer, so it can mistakenly return a non-zero
result.

r=me though, this is already a good improvement. Please add a FIXME if you
decide to land as is.