[webkit-reviews] review denied: [Bug 35811] [chromium] need DragImage implementation : [Attachment 50269] use WebImage, no mac implementation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 9 22:36:42 PST 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Evan Stade
<estade at chromium.org>'s request for review:
Bug 35811: [chromium] need DragImage implementation
https://bugs.webkit.org/show_bug.cgi?id=35811
Attachment 50269: use WebImage, no mac implementation
https://bugs.webkit.org/attachment.cgi?id=50269&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/public/WebViewClient.h
...
> virtual void startDragging(
> - const WebPoint& from, const WebDragData&, WebDragOperationsMask) { }
> + const WebDragData&, WebDragOperationsMask, const WebImage&, const
WebPoint&) { }
Can you avoid making this a two-sided patch landing by continuing
to support the old API temporarily?
> Index: WebKit/chromium/src/DragClientImpl.cpp
...
> +#if WEBKIT_USING_SKIA
> + m_webView->startDragging(
> + dragData, static_cast<WebDragOperationsMask>(dragOperationMask),
> + WebImage(*dragImage), offsetPoint);
> +#else
> + // FIXME
^^^ Can you add a comment about this FIXME? Something about needing
to pass a non-empty image perhaps?
Are the style bot issues something to worry about?
More information about the webkit-reviews
mailing list