[webkit-reviews] review granted: [Bug 35550] Allow a plugin to participate in the browser's print workflow. : [Attachment 50370] Updated patch with code review changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 9 22:09:48 PST 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted
sanjeevr at chromium.org's request for review:
Bug 35550: Allow a plugin to participate in the browser's print workflow.
https://bugs.webkit.org/show_bug.cgi?id=35550

Attachment 50370: Updated patch with code review changes
https://bugs.webkit.org/attachment.cgi?id=50370&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> +static WebPluginContainerImpl* pluginContainerFromFrame(Frame* frame)
> +{
> +    if (!frame)
> +	   return NULL;
> +    if (!frame->document() || !frame->document()->isPluginDocument())
> +	   return NULL;
> +    PluginDocument* pluginDocument =
static_cast<PluginDocument*>(frame->document());
> +    return static_cast<WebPluginContainerImpl
*>(pluginDocument->pluginWidget());
> +}

As the style bot says, NULL -> 0

R=me otherwise


More information about the webkit-reviews mailing list