[webkit-reviews] review granted: [Bug 35913] [EFL] Add ChromeClientEfl.{cpp, h} to WebKit/efl/WebCoreSupport. : [Attachment 50296] Add ChromeClientEfl to WK/efl/WebCoreSupport.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 9 21:05:44 PST 2010


Holger Freyther <zecke at selfish.org> has granted Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 35913: [EFL] Add ChromeClientEfl.{cpp,h} to WebKit/efl/WebCoreSupport.
https://bugs.webkit.org/show_bug.cgi?id=35913

Attachment 50296: Add ChromeClientEfl to WK/efl/WebCoreSupport.
https://bugs.webkit.org/attachment.cgi?id=50296&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> +    explicit ChromeClientEfl(Evas_Object *view);

style violation uncaught by the style bot... and the same for the Evas_Object*
m_view. Please create a follow up patch.


More information about the webkit-reviews mailing list