[webkit-reviews] review denied: [Bug 35885] [EFL] Add KURLEfl.cpp to WC/platform/efl. : [Attachment 50254] Add KURLEfl.cpp to WC/platform/efl

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has denied Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 35885: [EFL] Add KURLEfl.cpp to WC/platform/efl.
https://bugs.webkit.org/show_bug.cgi?id=35885

Attachment 50254: Add KURLEfl.cpp to WC/platform/efl
https://bugs.webkit.org/attachment.cgi?id=50254&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> +#include <Ecore.h>

the include is not needed.

> +
> +namespace WebCore {
> +
> +String KURL::fileSystemPath() const
> +{
> +    CString filename = m_string.utf8();
> +
> +    if (!filename.data())
> +	   return String();
> +
> +    String path = String::fromUTF8(filename.data());
> +    return path;

The implementation is totally bogus. You can easily steal the KURLQt.cpp
implementation
or at least take a look at that.