[webkit-reviews] review denied: [Bug 35909] [GTK] GTK_WIDGET_IS_SENSITIVE deprecated in GTK+ 2.20 : [Attachment 50287] proposed patch

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 35909: [GTK] GTK_WIDGET_IS_SENSITIVE deprecated in GTK+ 2.20
https://bugs.webkit.org/show_bug.cgi?id=35909

Attachment 50287: proposed patch
https://bugs.webkit.org/attachment.cgi?id=50287&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
I might miss my morning coffee... or people from shelbyville has put stuff into
the water...


> +	   [GTK] GTK_WIDGET_IS_SENSITIVE deprecated in GTK+ 2.20

please put a verb like "is" there to make it a sentence. :)


> +
> +#if GTK_CHECK_VERSION(2, 18, 0)
>      if (GTK_WIDGET_IS_SENSITIVE(widget)) {
> +#else
> +    if (GTK_WIDGET_IS_SENSITIVE(widget)) {
> +#endif

this looks identical. I think you want to make one of them
gtk_widget_is_sensitive?