[webkit-reviews] review granted: [Bug 35900] [Chromium] Need to send mouse events to plugin when it has mouse capture : [Attachment 50350] Updated patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted John
Abd-El-Malek <jam at chromium.org>'s request for review:
Bug 35900: [Chromium] Need to send mouse events to plugin when it has mouse
capture
https://bugs.webkit.org/show_bug.cgi?id=35900

Attachment 50350: Updated patch
https://bugs.webkit.org/attachment.cgi?id=50350&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/src/WebViewImpl.cpp
...
> +    if (m_haveMouseCapture &&
WebInputEvent::isMouseEventType(inputEvent.type)) {
> +	   Node* node = focusedWebCoreNode();
> +	   if (node && node->renderer() &&
node->renderer()->isEmbeddedObject()) {
> +	     AtomicString eventType;
> +	       switch (inputEvent.type) {

nit: indentation of AtomicString is off.


>  void WebViewImpl::mouseCaptureLost()
>  {
> +    m_haveMouseCapture = false;
>  }

We may eventually wish to pass this event along to the plugin.

Are there any compatibility concerns with enabling this patch for ordinary
plugins?