[webkit-reviews] review granted: [Bug 35846] Kill applicationID() (part 1) : [Attachment 50345] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Aaron Boodman
<aa at chromium.org>'s request for review:
Bug 35846: Kill applicationID() (part 1)
https://bugs.webkit.org/show_bug.cgi?id=35846

Attachment 50345: Patch
https://bugs.webkit.org/attachment.cgi?id=50345&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> +++ b/WebKit/chromium/public/WebNotificationPresenter.h
...
> +    virtual Permission checkPermission(const WebSecurityOrigin& origin)
> +    {
> +	   return PermissionNotAllowed;
> +    };

nit: no trailing semi-colon


> +++ b/WebKit/chromium/src/NotificationPresenterImpl.cpp
...
> +    int result = m_presenter->checkPermission(WebSecurityOrigin(origin));
> +
> +    // FIXME: Remove this once clients are updated to use the above
signature.
> +    if (result == NotificationPresenter::PermissionNotAllowed)

nit: you can drop the NotificationPresenter:: prefix here.


> +++ b/WebKit/win/WebCoreSupport/WebDesktopNotificationsDelegate.cpp
> @@ -174,8 +174,13 @@ void
WebDesktopNotificationsDelegate::requestPermission(SecurityOrigin* origin,
>  
>  NotificationPresenter::Permission
WebDesktopNotificationsDelegate::checkPermission(const KURL& url, Document*)
>  {
> +    return (NotificationPresenter::Permission) 0;

perhaps it would be better to explicitly return one of the enum values?
0 means PermissionAllowed, right?


r=me otherwise.  cq- since there are some nits to fix.