[webkit-reviews] review granted: [Bug 32288] :after selector displays in wrong place with nested div : [Attachment 50357] Patch v6

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 9 15:36:51 PST 2010


Darin Adler <darin at apple.com> has granted Valters Švābe <vsvabe at gmail.com>'s
request for review:
Bug 32288: :after selector displays in wrong place with nested div
https://bugs.webkit.org/show_bug.cgi?id=32288

Attachment 50357: Patch v6
https://bugs.webkit.org/attachment.cgi?id=50357&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   if (isAfterContent(lastRenderer))
> +	       beforeChild = lastRenderer;
> +	   else if (lastRenderer && lastRenderer->isAnonymousBlock() &&
isAfterContent(lastRenderer->lastChild()))
> +	       beforeChild = lastRenderer->lastChild();

Is there ever a case with more than one level of anonymous block? If so, we
might need a loop instead.

r=me


More information about the webkit-reviews mailing list