[webkit-reviews] review granted: [Bug 35713] undo after smartdelete should select the deleted space : [Attachment 49976] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 9 11:06:01 PST 2010
Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 35713: undo after smartdelete should select the deleted space
https://bugs.webkit.org/show_bug.cgi?id=35713
Attachment 49976: Patch
https://bugs.webkit.org/attachment.cgi?id=49976&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Ojan is slowly teaching me the editing code. I'd prefer to have someone more
expert review these patches, but no one seems to be forthcoming.
+ void setStartingSelectionOnSmartDelete(Position&, Position&);
Why pass these by reference instead of by constant reference?
More information about the webkit-reviews
mailing list