[webkit-reviews] review granted: [Bug 35498] check-webkit-style: Path checks should be done using absolute paths : [Attachment 50196] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 8 21:27:46 PST 2010


Shinichiro Hamaji <hamaji at chromium.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 35498: check-webkit-style: Path checks should be done using absolute paths
https://bugs.webkit.org/show_bug.cgi?id=35498

Attachment 50196: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=50196&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
OK.

If you checkout WebKit repository in a directory whose name is
"ForwardingHeaders", build/header_guard will be not checked for all files,
right? If so, I guess we may eventually want to modify the absolute path so
that it doesn't contain directories where the WebKit repository is put. Anyway,
I think this kind of situations are unlikely to happen for now.


More information about the webkit-reviews mailing list