[webkit-reviews] review denied: [Bug 35763] Remove the now-redundant Settings fields for the Database : [Attachment 50265] Fix the build fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 8 21:16:31 PST 2010


David Levin <levin at chromium.org> has denied Eric U. <ericu at chromium.org>'s
request for review:
Bug 35763: Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

Attachment 50265: Fix the build fix.
https://bugs.webkit.org/attachment.cgi?id=50265&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebKit/win/ChangeLog
> +2010-03-08  Eric Uhrhane  <ericu at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   The build fix for my patch on bug #35763 wasn't quite right--it
removed
> +	   the call entirely, instead of replacing it with the new API.  This
adds
> +	   the call to Database::setIsAvailable.

Please add a bug link here.

> Index: WebKit/win/WebView.cpp
> +    hr = prefsPrivate->databasesEnabled(&enabled);
> +    if (FAILED(hr))
> +	   return hr;
> +    Database::setIsAvailable(enabled);
> +

This needs an appropriate if ENABLE guard.


More information about the webkit-reviews mailing list