[webkit-reviews] review denied: [Bug 34452] Initial patch for audio engine: AudioBus and helper classes : [Attachment 47884] patch for some initial audio engine support classes: fixes some minor style problems with the initial patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 8 16:42:37 PST 2010
Adam Barth <abarth at webkit.org> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 34452: Initial patch for audio engine: AudioBus and helper classes
https://bugs.webkit.org/show_bug.cgi?id=34452
Attachment 47884: patch for some initial audio engine support classes: fixes
some minor style problems with the initial patch
https://bugs.webkit.org/attachment.cgi?id=47884&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Please add the zero() method to Vector instead of creating these subclasses.
You can use a trait to ensure that the method can't be used on a type that
causes problems.
More information about the webkit-reviews
mailing list