[webkit-reviews] review denied: [Bug 35333] [GTK] video playback position query flood when mouse over the video element : [Attachment 49802] updated patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 35333: [GTK] video playback position query flood when mouse over the video
element
https://bugs.webkit.org/show_bug.cgi?id=35333

Attachment 49802: updated patch
https://bugs.webkit.org/attachment.cgi?id=49802&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
 1572	  float maxTime = maxTimeSeekable();
15721573     // FIXME real ranges support
1573 	  if (!maxTimeSeekable())
 1574	  if (!maxTime)
15741575	 return TimeRanges::create();
1575 	  return TimeRanges::create(minTimeSeekable(), maxTimeSeekable());
 1576	  return TimeRanges::create(minTimeSeekable(), maxTime);

Unrelated micro-optimization? Is this really a problem? I'd put this in a
separate patch, and get Eric Carlson to look at it.

5864 // backend can live at runtime.
5965 typedef struct PlatformMedia {
6066	 QTMovie* qtMovie;
 67	GstElement* gstPipeline;
6168 } PlatformMedia;

This looks weird to me. I don't think our struct should have a QTMovie in it.
Maybe we need a #if/#else here, instead? Or event better, just write an
implementation for platformMedia that returns the playbin! See:

77	    virtual PlatformMedia platformMedia() const { return
NoPlatformMedia; }

676 	 return paintMediaButton(paintInfo.context, r, mediaElement->canPlay()
? m_playButton.get() : m_pauseButton.get(), m_panelColor, m_mediaIconSize);
 676	 return paintMediaButton(paintInfo.context, r, mediaElement->paused() ?
m_playButton.get() : m_pauseButton.get(), m_panelColor, m_mediaIconSize);

This seems totally unrelated?