[webkit-reviews] review requested: [Bug 35706] [GStreamer] Buffering logic is not correct, and does not work very well : [Attachment 50242] fix buffering logic to also consider non-download cases

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has asked  for review:
Bug 35706: [GStreamer] Buffering logic is not correct, and does not work very
well
https://bugs.webkit.org/show_bug.cgi?id=35706

Attachment 50242: fix buffering logic to also consider non-download cases
https://bugs.webkit.org/attachment.cgi?id=50242&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
So it turns out that the real problem was in using the on-disk-buffering logic
to pause/play the pipeline. GStreamer uses a buffering-percent value in the
struct that is sent to the bus in the buffering message to provide information
on how much of the immediate buffering it needs to play is actually complete.
That is the information we need to use to decide when to restart playing the
pipeline that got paused for buffering, not the fact that the on-disk buffering
has started.