[webkit-reviews] review granted: [Bug 35824] Relax 3rd party cookie policy in certain cases : [Attachment 50232] Fix for Mac + Win (tested on Windows, now)

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 35824: Relax 3rd party cookie policy in certain cases
https://bugs.webkit.org/show_bug.cgi?id=35824

Attachment 50232: Fix for Mac + Win (tested on Windows, now)
https://bugs.webkit.org/attachment.cgi?id=50232&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>

>      if (CFHTTPCookieStorageRef cookieStorage = currentCookieStorage()) {
>	   CFURLRequestSetHTTPCookieStorage(newRequest, cookieStorage);
> -	   CFURLRequestSetHTTPCookieStorageAcceptPolicy(newRequest,
CFHTTPCookieStorageGetCookieAcceptPolicy(cookieStorage));
> +	   CFHTTPCookieStorageAcceptPolicy policy =
CFHTTPCookieStorageGetCookieAcceptPolicy(cookieStorage);
> +	   CFURLRequestSetHTTPCookieStorageAcceptPolicy(newRequest, policy);
> +	   if (policy ==
CFHTTPCookieStorageAcceptPolicyOnlyFromMainDocumentDomain) {

You should add the same comment here that you added in ResourceHandleMac.mm.
Have you tried this on Tiger as well?

r=me