[webkit-reviews] review requested: [Bug 31533] webkitpy __init__.py (webkit-patch) should detect python < 2.5 and show a nice error message : [Attachment 50180] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 7 17:07:35 PST 2010


Chris Jerdonek <cjerdonek at webkit.org> has asked  for review:
Bug 31533: webkitpy __init__.py (webkit-patch) should detect python < 2.5 and
show a nice error message
https://bugs.webkit.org/show_bug.cgi?id=31533

Attachment 50180: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=50180&action=review

------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
I didn't add any information about how to upgrade.  Perhaps we can simply
include a link to this wiki page, and include instructions there:

http://trac.webkit.org/wiki/PythonGuidelines

Let me know your preference.

Also, note that pending patches in the following two reports are required for
this patch to work:

https://bugs.webkit.org/show_bug.cgi?id=35828
https://bugs.webkit.org/show_bug.cgi?id=35788

So the style bot may not work.	Also marking cq- for that reason.


More information about the webkit-reviews mailing list