[webkit-reviews] review requested: [Bug 24021] pseudo-element styles not accessible / retrievable via DOM methods : [Attachment 50157] First steps towards exposing the standard pseudo-elements through getComputedStyle

[bugzilla-daemon at webkit.org]

Jessie Berlin <jberlin at webkit.org> has asked  for review:
Bug 24021: pseudo-element styles not accessible / retrievable via DOM methods
https://bugs.webkit.org/show_bug.cgi?id=24021

Attachment 50157: First steps towards exposing the standard pseudo-elements
through getComputedStyle
https://bugs.webkit.org/attachment.cgi?id=50157&action=review

------- Additional Comments from Jessie Berlin <jberlin at webkit.org>
Following Dan's suggestion in comment #7 to start by just using the cached
Pseudo Style returned from the RenderStyle of the element on which the
pseudo-element is defined.

I am currently investigating how to get the renderer for the pseudo-element so
as to get the 'length' properties correct. Is there any point at which a render
style is created for a pseudo-element with the correct 'length' properties?
Even explicitly using the renderer()->firstLineStyle() does not return a
RenderStyle with the correct 'length' properties (testing with height), so I am
wondering if the correct RenderStyle is ever created ...

Preliminary (but not thorough) testing indicates that this patch returns the
same 'length' properties as Firefox does.

For the ':selection' pseudo-element, getting the cached Pseudo Style directly
from the renderer of the element on which the pseudo-element is defined seems
to work for properties like color, but still does not work for 'length'
properties.