[webkit-reviews] review requested: [Bug 35833] Clean IntRect : [Attachment 50155] Inline + cleaning

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 6 13:25:22 PST 2010


Benjamin Poulain <benjamin.poulain at nokia.com> has asked  for review:
Bug 35833: Clean IntRect
https://bugs.webkit.org/show_bug.cgi?id=35833

Attachment 50155: Inline + cleaning
https://bugs.webkit.org/attachment.cgi?id=50155&action=review

------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
Make IntRect::intersects() inline.
Remove IntRect::IntRect(const FloatRect) because I cannot find it used
anywhere.
Compile scale(float) only if there is the dashboard support

I really only care about intersects() being inline. Removing the two unused
functions is just because I am tired of people complaining of the size of
Webkit... ;)


More information about the webkit-reviews mailing list