[webkit-reviews] review canceled: [Bug 35702] [Qt] Add more support for InputTextController : [Attachment 50150] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 6 06:25:12 PST 2010


Robert Hogan <robert at roberthogan.net> has canceled Robert Hogan
<robert at roberthogan.net>'s request for review:
Bug 35702: [Qt] Add more support for InputTextController
https://bugs.webkit.org/show_bug.cgi?id=35702

Attachment 50150: Patch
https://bugs.webkit.org/attachment.cgi?id=50150&action=review

------- Additional Comments from Robert Hogan <robert at roberthogan.net>
Fix style and < 4.6 build.

The bot is running 4.5 or less, and the tests won't pass on less than 4.6 due
to the need to QInputMethodQuery::Selection. So maybe this patch is blocked
until the bot upgrades? How does this sort of thing usually work, when a fix is
Qt version dependent?


More information about the webkit-reviews mailing list