[webkit-reviews] review denied: [Bug 35824] Relax 3rd party cookie policy in certain cases : [Attachment 50145] Fix for Mac + Win
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Mar 6 00:50:43 PST 2010
mitz at webkit.org has denied Brady Eidson <beidson at apple.com>'s request for
review:
Bug 35824: Relax 3rd party cookie policy in certain cases
https://bugs.webkit.org/show_bug.cgi?id=35824
Attachment 50145: Fix for Mac + Win
https://bugs.webkit.org/attachment.cgi?id=50145&action=review
------- Additional Comments from mitz at webkit.org
> - CFURLRequestSetHTTPCookieStorageAcceptPolicy(newRequest,
CFHTTPCookieStorageGetCookieAcceptPolicy(cookieStorage));
> +
> + int policy = CFHTTPCookieStorageAcceptPolicy(cookieStorage);
I think you meant to use CFHTTPCookieStorageGetCookieAcceptPolicy()! This is
just casting cookieStorage to a CFHTTPCookieStorageAcceptPolicy, which happens
to be int. So this should be
CFHTTPCookieStorageAcceptPolicy policy =
CFHTTPCookieStorageGetCookieAcceptPolicy(cookieStorage);
I didn’t review the rest of the patch, but r- based on that. Sorry.
More information about the webkit-reviews
mailing list