[webkit-reviews] review denied: [Bug 35499] webkitpy: Move webkitpy/mock.py into webkitpy/thirdparty : [Attachment 49701] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 5 15:11:53 PST 2010
Eric Seidel <eric at webkit.org> has denied Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 35499: webkitpy: Move webkitpy/mock.py into webkitpy/thirdparty
https://bugs.webkit.org/show_bug.cgi?id=35499
Attachment 49701: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=49701&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Why not just fix all the commands?
webkitpy/commands_references.py
Seems cleaner to just fix all the commands instead of using
commands_references. Otherwise this looks fine.
I think ..foo_references is actually quite hard to read. And it's inconsistent
throughout all our files. I think we should just import these directly, no?
More information about the webkit-reviews
mailing list