[webkit-reviews] review requested: [Bug 33884] [Chromium] spurious WebViewClient::didStopLoading if changing location.hash while a subframe is still loading : [Attachment 50118] v1 patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 5 14:07:05 PST 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has asked  for review:
Bug 33884: [Chromium] spurious WebViewClient::didStopLoading if changing
location.hash while a subframe is still loading
https://bugs.webkit.org/show_bug.cgi?id=33884

Attachment 50118: v1 patch
https://bugs.webkit.org/attachment.cgi?id=50118&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
This is a less aggressive solution.  Just check to see if any subframes are
also loading.  isLoadingInAPISense checks this frame as well as any of its
subframes, which is exactly what we want.


More information about the webkit-reviews mailing list