[webkit-reviews] review denied: [Bug 35727] [GTK] GTK_WIDGET_NO_WINDOW deprecated in GTK+ 2.20 : [Attachment 49999] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 5 13:17:39 PST 2010


Eric Seidel <eric at webkit.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 35727: [GTK] GTK_WIDGET_NO_WINDOW deprecated in GTK+ 2.20
https://bugs.webkit.org/show_bug.cgi?id=35727

Attachment 49999: proposed patch
https://bugs.webkit.org/attachment.cgi?id=49999&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Can we wrap this in some helper function?  Copy/paste 4 times seems silly. 
Even if we just used a helper function in GtkWidget.cpp that would be better
than this.


More information about the webkit-reviews mailing list