[webkit-reviews] review granted: [Bug 35798] Crash due to infinite recursion when viewing composited video on Windows : [Attachment 50109] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 35798: Crash due to infinite recursion when viewing composited video on
Windows
https://bugs.webkit.org/show_bug.cgi?id=35798

Attachment 50109: Patch
https://bugs.webkit.org/attachment.cgi?id=50109&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/platform/graphics/win/GraphicsLayerCACF.cpp
> ===================================================================

> +class WebLayer : public WKCACFLayer {

> +private:
> +   GraphicsLayerCACF* m_owner;
> +};

Could WebLayer get away with having pointer to the base class (GraphicsLayer?).
No point making it too incestuous with GraphicsLayerCACF if you can avoid it.

This this a great improvement to these classes!