[webkit-reviews] review denied: [Bug 35796] Accept and bailout NULL widgets in ChromiumBridge : [Attachment 50102] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 5 11:32:23 PST 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied anton muhin
<antonm at chromium.org>'s request for review:
Bug 35796: Accept and bailout NULL widgets in ChromiumBridge
https://bugs.webkit.org/show_bug.cgi?id=35796

Attachment 50102: Patch
https://bugs.webkit.org/attachment.cgi?id=50102&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
> index 93a474b..f2de64e 100644
> --- a/WebKit/chromium/ChangeLog
> +++ b/WebKit/chromium/ChangeLog
> @@ -1,3 +1,22 @@
> +2010-03-05  Anton Muhin  <antonm at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Accept and bailout NULL widgets in ChromiumBridge
> +	   https://bugs.webkit.org/show_bug.cgi?id=35796
> +
> +	   * src/ChromiumBridge.cpp:
> +	   (WebCore::toChromeClientImpl):
> +
> +2010-03-05  anton muhin  <antonm at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Need a short description and bug URL (OOPS!)
> +
> +	   * src/ChromiumBridge.cpp:
> +	   (WebCore::toChromeClientImpl):

^^^ duplicate changelog entries?

also, please create a layout test for this.


More information about the webkit-reviews mailing list