[webkit-reviews] review granted: [Bug 35758] [Chromium] Pass the WebFrameClient into WebStorageArea::setItem so we can figure out the routing ID : [Attachment 50094] Addressed comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 5 10:49:50 PST 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 35758: [Chromium] Pass the WebFrameClient into WebStorageArea::setItem so
we can figure out the routing ID
https://bugs.webkit.org/show_bug.cgi?id=35758

Attachment 50094: Addressed comments
https://bugs.webkit.org/attachment.cgi?id=50094&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> +    virtual void setItem(const WebString& key, const WebString& newValue,
const WebURL& url, Result& result, WebString& oldValue, WebView*)

nit: it occurred to me that passing the WebView loses information.  passing the
WebFrame
might be better, although it doesn't matter to chromium.

r=me


More information about the webkit-reviews mailing list