[webkit-reviews] review granted: [Bug 35723] Refactoring: window.btoa() and window.atob() should be implemented on DOMWindow : [Attachment 50083] v3; rename hasMultibyteCharacters to isSafeToConvertCharList
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 5 10:03:35 PST 2010
Darin Adler <darin at apple.com> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 35723: Refactoring: window.btoa() and window.atob() should be implemented
on DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=35723
Attachment 50083: v3; rename hasMultibyteCharacters to isSafeToConvertCharList
https://bugs.webkit.org/attachment.cgi?id=50083&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> +static bool isSafeToConvertCharList(const String& string)
This is probably better than the old name, but I would have used a name like
containsOnlyEightBitCharacters. Sorry I didn't suggest a name last time. r=me
either with your name or with my suggested name.
More information about the webkit-reviews
mailing list