[webkit-reviews] review requested: [Bug 34936] [Chromium] Typing into Flash with wmode = opaque|transparent and non-latin language active outputs as if US keyboard layout active : [Attachment 50089] A webkit-side fix 3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 4 23:22:29 PST 2010


Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 34936: [Chromium] Typing into Flash with wmode = opaque|transparent and
non-latin language active outputs as if US keyboard layout active
https://bugs.webkit.org/show_bug.cgi?id=34936

Attachment 50089: A webkit-side fix 3
https://bugs.webkit.org/attachment.cgi?id=50089&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
(In reply to comment #5)
> You might need to null check node->renderer() before de-referencing it.
> Most code does so.

Thank you for your comment and sorry for my bonehead mistake. I have added the
null check here.
Is it possible to review the updated one?

Regards,

Hironori Bono


More information about the webkit-reviews mailing list