[webkit-reviews] review granted: [Bug 35723] Refactoring: window.btoa() and window.atob() should be implemented on DOMWindow : [Attachment 50075] v2; follow the feedback, cleanup a little

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 35723: Refactoring: window.btoa() and window.atob() should be implemented
on DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=35723

Attachment 50075: v2; follow the feedback, cleanup a little
https://bugs.webkit.org/attachment.cgi?id=50075&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +static bool hasMultibyteCharacters(const String& string)
> +{
> +    for (unsigned i = 0; i < string.length(); i++) {
> +	   if (string[i] > 0xFF)
> +	       return true;
> +    }
> +
> +    return false;
> +}

This is not a great name for this function. I don’t really think of U+0040 as a
“single byte” character nor do I think of U+0100 as “multi-byte”.

Patch otherwise seems OK.

r=me