[webkit-reviews] review denied: [Bug 35771] [chromium] WebDocument:applicationID() crashes on <meta> tag with no http-equiv attribute : [Attachment 50062] fix style warning

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 4 16:39:21 PST 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied John Gregg
<johnnyg at google.com>'s request for review:
Bug 35771: [chromium] WebDocument:applicationID() crashes on <meta> tag with no
http-equiv attribute
https://bugs.webkit.org/show_bug.cgi?id=35771

Attachment 50062: fix style warning
https://bugs.webkit.org/attachment.cgi?id=50062&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/src/WebDocument.cpp
> +	   if (element->hasAttribute("http-equiv")
> +	       && element->getAttribute("http-equiv").lower() ==
kChromeApplicationHeader) {
>	       return element->getAttribute("value");
>	   }

nit: there should be no brackets around single line statements


More information about the webkit-reviews mailing list