[webkit-reviews] review denied: [Bug 35760] [Chromium] Adding Chromium -> WebCore touch type conversions : [Attachment 50043] Initial patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Garret Kelly (Google)
<gdk at chromium.org>'s request for review:
Bug 35760: [Chromium] Adding Chromium -> WebCore touch type conversions
https://bugs.webkit.org/show_bug.cgi?id=35760

Attachment 50043: Initial patch
https://bugs.webkit.org/attachment.cgi?id=50043&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Aren't PlatformTouchEvent used as stack objects?  They're not ref-counted, so I
assume no one holds pointers to them.  In that case, virtual methods (like
virtual destructors) make no sense!

This seems like the wrong model.  Normally Platform*Event classes are passed a
WebKit-layer class pointer and they convert that.  This seems to be going the
opposite way for reasons I dont' understand.