[webkit-reviews] review granted: [Bug 35570] WebSocket onmessageerror event handler : [Attachment 49990] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 35570: WebSocket onmessageerror event handler
https://bugs.webkit.org/show_bug.cgi?id=35570

Attachment 49990: Patch
https://bugs.webkit.org/attachment.cgi?id=49990&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +void WebSocket::didReceiveMessageError()
> +{
> +    LOG(Network, "WebSocket %p didReceiveErrorMessage", this);
> +    if (m_state != OPEN || !scriptExecutionContext())
> +	   return;

Can both these conditions really occur? Seems acceptable to be a little
defensive, but maybe there should also be ASSERTs if this isn't supposed to
happen. Otherwise, these checks can confuse someone about how this code works.

r=me