[webkit-reviews] review denied: [Bug 35723] Refactoring: window.btoa() and window.atob() should be implemented on DOMWindow : [Attachment 49998] v1; fix style violations

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied MORITA Hajime <morrita at google.com>'s
request for review:
Bug 35723: Refactoring: window.btoa() and window.atob() should be implemented
on DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=35723

Attachment 49998: v1; fix style violations
https://bugs.webkit.org/attachment.cgi?id=49998&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    return jsString(exec, String(out.data(), out.size()));
> +    return jsString(exec, String(result.characters(), result.length()));

This is wrong. It makes an extra copy of the entire string! It should just be
jsString(exec, result).