[webkit-reviews] review granted: [Bug 32711] [gtk] Make paths relocatable on runtime : [Attachment 50027] Patch modified not to use String::format

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 4 09:10:09 PST 2010


Holger Freyther <zecke at selfish.org> has granted Fridrich Strba
<fridrich.strba at bluewin.ch>'s request for review:
Bug 32711: [gtk] Make paths relocatable on runtime
https://bugs.webkit.org/show_bug.cgi?id=32711

Attachment 50027: Patch modified not to use String::format
https://bugs.webkit.org/attachment.cgi?id=50027&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
I don't know if that is the best thing to do, but it seems to make sense and it
has no impact on UNIX for WebKitGTK+ and we don't seem to leak memory.


> +static char *
> +get_webkit_datadir(void)

I think this is a small style violation, but I see that we copy the code from
other places.


More information about the webkit-reviews mailing list