[webkit-reviews] review requested: [Bug 35577] [Qt] QScriptConverter::toString() should use QVarLengthArray instead of QByteArray : [Attachment 50008] Fix v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 4 05:56:01 PST 2010
Jędrzej Nowacki <jedrzej.nowacki at nokia.com> has asked for review:
Bug 35577: [Qt] QScriptConverter::toString() should use QVarLengthArray instead
of QByteArray
https://bugs.webkit.org/show_bug.cgi?id=35577
Attachment 50008: Fix v1
https://bugs.webkit.org/attachment.cgi?id=50008&action=review
------- Additional Comments from Jędrzej Nowacki <jedrzej.nowacki at nokia.com>
The patch reduces run time of the QScriptValue::toString() about 2 ms per
iteration. So it is about 3.5% speed gain in a simple benchmark like this:
{
QScriptValue v(112312.234334);
QBENCHMARK {
v.toString();
}
}
More information about the webkit-reviews
mailing list