[webkit-reviews] review denied: [Bug 34347] MathML Support for mrow and Stretchy Operators : [Attachment 49928] Fixed style errors...
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 4 04:40:36 PST 2010
Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Alex Milowski
<alex at milowski.com>'s request for review:
Bug 34347: MathML Support for mrow and Stretchy Operators
https://bugs.webkit.org/show_bug.cgi?id=34347
Attachment 49928: Fixed style errors...
https://bugs.webkit.org/attachment.cgi?id=49928&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
Looks better but still some issues :-) r- because of inconsistency with
variable/comment
129 Element* mo = 0;
130 if (node()->nodeType() == Node::ELEMENT_NODE) {
131 mo = static_cast<Element*>(node());
132 if (mo) {
You don't seem to use mo outside, so you could do
if (Element* mo = static_cast<Element*>(node())) {
...
}
150 // canStretch indicates whether the character is streatchable via a
number of factors.
151 bool isStretchy = false;
Please fix the comment or variable.
195
196 } else {
unneeded newline
260 }
261
262 }
same thing
More information about the webkit-reviews
mailing list