[webkit-reviews] review requested: [Bug 34936] [Chromium] Typing into Flash with wmode = opaque|transparent and non-latin language active outputs as if US keyboard layout active : [Attachment 50002] A webKit-side fix 2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 4 03:00:20 PST 2010
Hironori Bono <hbono at chromium.org> has asked for review:
Bug 34936: [Chromium] Typing into Flash with wmode = opaque|transparent and
non-latin language active outputs as if US keyboard layout active
https://bugs.webkit.org/show_bug.cgi?id=34936
Attachment 50002: A webKit-side fix 2
https://bugs.webkit.org/attachment.cgi?id=50002&action=review
------- Additional Comments from Hironori Bono <hbono at chromium.org>
Thank you for your review and comments.
(In reply to comment #2)
> An <object> tag can be more than just a plug-in. It would
> probably be better check the renderer to see if it is a plug-in
> via node->renderer()->isEmbeddedObject().
Thank you for noticing this function. I wasn't aware that WebKit has such a
convenient function.
Since I have updated this change to use this function, is it possible to review
the updated one?
Regards,
Hironori Bono
More information about the webkit-reviews
mailing list