[webkit-reviews] review denied: [Bug 34936] [Chromium] Typing into Flash with wmode = opaque|transparent and non-latin language active outputs as if US keyboard layout active : [Attachment 49269] A WebKit-side fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 3 23:18:11 PST 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Hironori Bono
<hbono at chromium.org>'s request for review:
Bug 34936: [Chromium] Typing into Flash with wmode = opaque|transparent and
non-latin language active outputs as if US keyboard layout active
https://bugs.webkit.org/show_bug.cgi?id=34936

Attachment 49269: A WebKit-side fix
https://bugs.webkit.org/attachment.cgi?id=49269&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/src/WebViewImpl.cpp
...
> @@ -507,8 +507,13 @@ bool WebViewImpl::keyEvent(const WebKeyb
>      PlatformKeyboardEventBuilder evt(event);
>  
>      if (handler->keyEvent(evt)) {
> -	   if (WebInputEvent::RawKeyDown == event.type)
> -	       m_suppressNextKeypressEvent = true;
> +	   if (WebInputEvent::RawKeyDown == event.type) {
> +	       // Suppress the next keypress event unless the focused node is a
plug-in node.
> +	       // (Flash needs these keypress events to handle non-US
keyboards.)
> +	       Node* node = frame->document()->focusedNode();
> +	       if (!node || (!node->hasTagName(HTMLNames::embedTag) &&
!node->hasTagName(HTMLNames::objectTag)))

An <object> tag can be more than just a plug-in.  It would
probably be better check the renderer to see if it is a plug-in
via node->renderer()->isEmbeddedObject().

Otherwise, I think this change is good.  Nice work on the test!


More information about the webkit-reviews mailing list